Klaster1 commented on a change in pull request #5869: IGNITE-10993 Web console
cancel query
URL: https://github.com/apache/ignite/pull/5869#discussion_r249680288
##########
File path:
modules/web-console/frontend/app/components/page-queries/components/queries-notebook/controller.ts
##########
@@ -1904,6 +2057,22 @@ export class NotebookCtrl {
$modal({scope, templateUrl: messageTemplateUrl, show: true});
}
};
+
+ $window.addEventListener('beforeunload', () => {
Review comment:
1. Every subsequent page enter will add new event listener. You should at
least remove it when leaving the state.
2. I'm not sure this should be a thing at all. Maybe consider cancelling
queries when client session is over (but this might cause issues with faulty
network connection). Or just leave queries running, we don't cancel any other
requests or long running operations (or do we?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
