Klaster1 commented on a change in pull request #6021: IGNITE-11035 Updates in
queries page.
URL: https://github.com/apache/ignite/pull/6021#discussion_r253744200
##########
File path:
modules/web-console/frontend/app/components/page-queries/components/queries-notebook/controller.ts
##########
@@ -2130,9 +2261,13 @@ export class NotebookCtrl {
async removeParagraph(paragraph: Paragraph) {
Review comment:
When removing instances of Paragraph, you might want to dispose of Subjects
by calling
[`Subject.complete`](https://github.com/ReactiveX/rxjs/blob/6.4.0/src/internal/Subject.ts#L91).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
