Mmuzaf commented on a change in pull request #5711: IGNITE-10748: remove dead
code
URL: https://github.com/apache/ignite/pull/5711#discussion_r253769358
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -3650,34 +3693,33 @@ private void safeShmemHandshake(
* Performs handshake in timeout-safe way.
*
* @param ch Socket channel.
- * @param recovery Recovery descriptor if use recovery handshake,
otherwise {@code null}.
* @param rmtNodeId Remote node.
* @param timeout Timeout for handshake.
* @param sslMeta Session meta.
- * @param handshakeConnIdx Non null connection index if need send it in
handshake.
+ * @param msg {@link HandshakeMessage} or {@link HandshakeMessage2} to
send.
* @return Handshake response.
* @throws IgniteCheckedException If handshake failed or wasn't completed
withing timeout.
*/
@SuppressWarnings("ThrowFromFinallyBlock")
private long safeTcpHandshake(
SocketChannel ch,
- @Nullable GridNioRecoveryDescriptor recovery,
UUID rmtNodeId,
long timeout,
GridSslMeta sslMeta,
- @Nullable Integer handshakeConnIdx
+ HandshakeMessage msg
) throws IgniteCheckedException {
HandshakeTimeoutObject obj = new HandshakeTimeoutObject<>(ch,
U.currentTimeMillis() + timeout);
addTimeoutObject(obj);
- long rcvCnt = 0;
+ long rcvCnt;
try {
BlockingSslHandler sslHnd = null;
ByteBuffer buf;
+ // Step 1. Get remote node respose with remote nodeId.
Review comment:
Fixed and fixed english grammar too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
