vldpyatkov commented on a change in pull request #6120: IGNITE-11332 Add jmx
ability to exclude node from topology.
URL: https://github.com/apache/ignite/pull/6120#discussion_r257908285
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java
##########
@@ -2497,6 +2497,11 @@ boolean cancel() {
return String.valueOf(getLocalNode());
}
+ /** {@inheritDoc} */
+ @Override public void excludeNode(String nodeId) {
+ impl.failNode(UUID.fromString(nodeId), "Node failed from JMX
interface, initiator=" + getLocalNodeId());
Review comment:
Why you are using different terms: "exclude" on comment, but "failed" on log
message.
Should to use one.
I think "exclude" more fit with the minding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
