vveider commented on a change in pull request #6119: IGNITE-11277: maven
checkstyle plugin config
URL: https://github.com/apache/ignite/pull/6119#discussion_r262421912
##########
File path: parent/pom.xml
##########
@@ -1313,8 +1314,6 @@
<id>checkstyle</id>
<activation>
- <activeByDefault>true</activeByDefault>
-
<property>
<name>skipTests</name>
Review comment:
Does this property definition means that when `-DskipTests` is called,
`checkstyle` profile will be activated?
And if so - what's the point of this action? By calling `-DskipTests` we
usually trying to skip as much of non build related steps as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
