ashapkin commented on a change in pull request #6427: IGNITE-11690 .NET: Unable
to locate external assembly with enabled peerAssemblyLoading
URL: https://github.com/apache/ignite/pull/6427#discussion_r274054723
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Deployment/PeerAssemblyResolver.cs
##########
@@ -36,16 +37,29 @@ internal sealed class PeerAssemblyResolver : IDisposable
/** Assembly resolve handler. */
private readonly ResolveEventHandler _handler;
+ /** DataSlot name to be examined during peer loading */
+ private const string DisablePeerLoadingMark = "DisablePeerLoading";
+
/// <summary>
/// Initializes a new instance of the <see
cref="PeerAssemblyResolver"/> class.
/// </summary>
public PeerAssemblyResolver(IIgniteInternal ignite, Guid originNodeId)
{
Debug.Assert(ignite != null);
- _handler = (sender, args) => GetAssembly(ignite, args.Name,
originNodeId);
+ _handler = (sender, args) =>
+ {
+ object result =
CallContext.LogicalGetData(DisablePeerLoadingMark);
Review comment:
There are multiple calls to `GetAssembly` method , the goal was to reduce an
amount of auxiliary checks for all cases except the particular one. I think we
can extract a helper method for a better readability. Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
