EdShangGG commented on a change in pull request #6330: IGNITE-11592 NPE in case of continuing tx and cache stop operation URL: https://github.com/apache/ignite/pull/6330#discussion_r285571897
########## File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxOnCachesStopTest.java ########## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.transactions; + +import org.apache.ignite.Ignite; +import org.apache.ignite.IgniteCache; +import org.apache.ignite.IgniteCacheRestartingException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.Ignition; +import org.apache.ignite.cache.CacheAtomicityMode; +import org.apache.ignite.cache.CacheWriteSynchronizationMode; +import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction; +import org.apache.ignite.configuration.CacheConfiguration; +import org.apache.ignite.configuration.DataRegionConfiguration; +import org.apache.ignite.configuration.DataStorageConfiguration; +import org.apache.ignite.configuration.IgniteConfiguration; +import org.apache.ignite.configuration.WALMode; +import org.apache.ignite.internal.IgniteEx; +import org.apache.ignite.internal.IgniteInternalFuture; +import org.apache.ignite.internal.IgniteInterruptedCheckedException; +import org.apache.ignite.internal.TestRecordingCommunicationSpi; +import org.apache.ignite.internal.processors.cache.CacheInvalidStateException; +import org.apache.ignite.internal.processors.cache.CacheStoppedException; +import org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxPrepareRequest; +import org.apache.ignite.internal.transactions.IgniteTxTimeoutCheckedException; +import org.apache.ignite.internal.util.GridRandom; +import org.apache.ignite.internal.util.typedef.X; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi; +import org.apache.ignite.spi.discovery.tcp.ipfinder.TcpDiscoveryIpFinder; +import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder; +import org.apache.ignite.testframework.GridTestUtils; +import org.apache.ignite.testframework.MvccFeatureChecker; +import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; +import org.apache.ignite.transactions.Transaction; +import org.apache.ignite.transactions.TransactionConcurrency; +import org.apache.ignite.transactions.TransactionIsolation; +import org.apache.ignite.transactions.TransactionRollbackException; +import org.junit.Test; + +import java.util.concurrent.CountDownLatch; + +/** + * + */ +public class TxOnCachesStopTest extends GridCommonAbstractTest { + /** Ip finder. */ + private static final TcpDiscoveryIpFinder ipFinder = new TcpDiscoveryVmIpFinder(true); + + /** Cache1 name. */ + private static final String CACHE_1_NAME = "cache1"; + + /** Cache2 name. */ + private static final String CACHE_2_NAME = "cache2"; + + /** rnd instance. */ + private static final GridRandom rnd = new GridRandom(); + + /** */ + private static CacheConfiguration<Integer, byte[]> destroyCacheCfg; + + /** */ + private static CacheConfiguration<Integer, byte[]> surviveCacheCfg; + + /** {@inheritDoc} */ + @Override protected IgniteConfiguration getConfiguration(String gridName) throws Exception { + IgniteConfiguration cfg = super.getConfiguration(gridName); + + TcpDiscoverySpi discoverySpi = (TcpDiscoverySpi)cfg.getDiscoverySpi(); + discoverySpi.setIpFinder(ipFinder); + + TestRecordingCommunicationSpi commSpi = new TestRecordingCommunicationSpi(); + cfg.setCommunicationSpi(commSpi); + + DataStorageConfiguration memCfg = new DataStorageConfiguration() + .setDefaultDataRegionConfiguration( + new DataRegionConfiguration().setMaxSize(100 * 1024 * 1024).setPersistenceEnabled(true)) + .setWalMode(WALMode.LOG_ONLY); + + cfg.setDataStorageConfiguration(memCfg); + + CacheConfiguration<Integer, byte[]> ccfg1 = new CacheConfiguration<>(); + + ccfg1.setName(CACHE_1_NAME); + ccfg1.setBackups(1); + ccfg1.setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL); + ccfg1.setWriteSynchronizationMode(CacheWriteSynchronizationMode.FULL_SYNC); + ccfg1.setAffinity(new RendezvousAffinityFunction(false, 32)); + + destroyCacheCfg = ccfg1; + + CacheConfiguration<Integer, byte[]> ccfg2 = new CacheConfiguration<>(); + + ccfg2.setName(CACHE_2_NAME); + ccfg2.setBackups(1); + ccfg2.setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL); + ccfg2.setWriteSynchronizationMode(CacheWriteSynchronizationMode.FULL_SYNC); + ccfg2.setAffinity(new RendezvousAffinityFunction(false, 32)); + + surviveCacheCfg = ccfg2; + + cfg.setCacheConfiguration(ccfg1, ccfg2); + + return cfg; + } + + /** {@inheritDoc} */ + @Override protected void beforeTest() throws Exception { + super.beforeTest(); + + stopAllGrids(); + + cleanPersistenceDir(); + } + + /** {@inheritDoc} */ + @Override protected void afterTest() throws Exception { + super.afterTest(); + + stopAllGrids(); + + cleanPersistenceDir(); + } + + /** + * @throws Exception If failed. + */ + @Test + public void testTxOnCacheStop() throws Exception { + startGrids(2); + + Ignition.setClientMode(true); + + IgniteEx ig = startGrid("client"); + + ig.cluster().active(true); + + for (TransactionConcurrency conc : TransactionConcurrency.values()) + for (TransactionIsolation iso : TransactionIsolation.values()) + runTxOnCacheStop(conc, iso, ig, true); + + ig.getOrCreateCache(destroyCacheCfg).destroy(); + ig.getOrCreateCache(surviveCacheCfg).destroy(); + + for (TransactionConcurrency conc : TransactionConcurrency.values()) + for (TransactionIsolation iso : TransactionIsolation.values()) + runTxOnCacheStop(conc, iso, ig, false); + + ig.getOrCreateCache(destroyCacheCfg).destroy(); + ig.getOrCreateCache(surviveCacheCfg).destroy(); + + for (TransactionConcurrency conc : TransactionConcurrency.values()) + for (TransactionIsolation iso : TransactionIsolation.values()) + runCacheStopInMidTx(conc, iso, ig); + + ig.cluster().active(false); + } + + /** + * @throws Exception If failed. + */ + private void runTxOnCacheStop(TransactionConcurrency conc, TransactionIsolation iso, Ignite ig, boolean runConc) + throws Exception { + if ((conc == TransactionConcurrency.OPTIMISTIC) && (MvccFeatureChecker.forcedMvcc())) + return; + + CountDownLatch destroyLatch = new CountDownLatch(1); + + final IgniteCache<Integer, byte[]> cache = ig.getOrCreateCache(destroyCacheCfg); + + final IgniteCache<Integer, byte[]> cache2 = ig.getOrCreateCache(surviveCacheCfg); + + TestRecordingCommunicationSpi spi = TestRecordingCommunicationSpi.spi(ig); + + IgniteInternalFuture f0 = GridTestUtils.runAsync(() -> { + try { + destroyLatch.await(); + + IgniteInternalFuture fInt = GridTestUtils.runAsync(() -> { Review comment: fInt? Just f looks better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
