pavlukhin commented on a change in pull request #6770: IGNITE-12061 Fix inline
size change.
URL: https://github.com/apache/ignite/pull/6770#discussion_r315573027
##########
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/SchemaManager.java
##########
@@ -616,6 +616,12 @@ public void dropIndex(final String schemaName, String
idxName, boolean ifExists)
throws IgniteCheckedException{
String sql = H2Utils.indexDropSql(schemaName, idxName, ifExists);
+ GridH2Table tbl = dataTableForIndex(schemaName, idxName);
+
+ assert tbl != null;
+
+ tbl.setRemoveIndexOnDestroy(true);
Review comment:
> Possibly, GridQueryProcessor should wait for active
SchemaOperationManager.worker-s before idx.unregisterCache(), but this should
be investigated.
Will be good to check it. AFAIK, cancellation uses `Thread.interrupt`, which
cannot cancel running `setRemoveIndexOnDestroy` method alone.
Also, I think that it would be great to separate an intent of _removing_
indexes on per-operation basis rather than having a single boolean flag shared
between different operations (cache stop, drop index).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
