alex-plekhanov commented on a change in pull request #6845: IGNITE-12145:
Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323291708
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/GridMetricManager.java
##########
@@ -265,45 +378,116 @@ public MetricRegistry registry(String name) {
return registries.computeIfAbsent(name, n -> {
MetricRegistry mreg = new MetricRegistry(name, log);
- notifyListeners(mreg, metricRegCreationLsnrs);
+ notifyListeners(mreg, metricRegCreationLsnrs, log);
return mreg;
});
}
- /** {@inheritDoc} */
- @NotNull @Override public Iterator<MetricRegistry> iterator() {
- return registries.values().iterator();
+ public <R extends MonitoringRow, D> void list(String name, String
description,
Review comment:
Perhaps `createList` is a better name since you already have overloaded
method with the same name, which only returns the existing list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
