alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. URL: https://github.com/apache/ignite/pull/6845#discussion_r323618617
########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/list/MonitoringListAdapter.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.metric.list; + +import java.util.Iterator; +import java.util.concurrent.ConcurrentMap; +import java.util.function.Function; +import org.apache.ignite.spi.metric.list.MonitoringRow; +import org.apache.ignite.spi.metric.list.MonitoringRowAttributeWalker; +import org.jetbrains.annotations.NotNull; + +/** + * Monitoring list backed by {@code data} {@link ConcurrentMap}. + */ +public class MonitoringListAdapter<R extends MonitoringRow, D> extends AbstractMonitoringList<R> { + /** Data backed by this list. */ + private final ConcurrentMap<?, D> data; Review comment: How you will force a user to pass thread-safety implementation of collection if there will have another implementation of `MonitoringList` which consumes `Collection`? I think it's not a reason to use extended class only to state it's thread safety. Also, you can state about thread safety in JavaDoc . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
