alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: 
Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323750481
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/spi/metric/list/MonitoringRowAttributeWalker.java
 ##########
 @@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.metric.list;
+
+/**
+ * Utility class for quick iteration over {@link MonitoringRow} properties.
+ */
+public interface MonitoringRowAttributeWalker<R extends MonitoringRow> {
+    /** @return Count of a row properties. */
+    public int count();
+
+    /**
+     * Calls visitor for each {@link MonitoringRow} attribute.
+     *
+     * @param visitor Attribute visitor.
+     */
+    public void visitAll(AttributeVisitor visitor);
+
+    /**
+     * Calls visitor for each {@link MonitoringRow} attribute.
+     * Value of the attribute also provided.
+     *
+     * @param row Row to iterate.
+     * @param visitor Attribute visitor.
+     */
+    public void visitAll(R row, AttributeWithValueVisitor visitor);
+
+    /** Attribute visitor. */
+    public interface AttributeVisitor {
+        /**
+         * Visit some object property.
+         * @param idx Index.
+         * @param name Name.
+         * @param clazz Value class.
+         * @param <T> Value type.
+         */
+        public <T> void accept(int idx, String name, Class<T> clazz);
+
+        /**
+         * Visit attribute. Attribute value is {@code boolean} primitive.
+         *
+         * @param idx Index.
+         * @param name Name.
+         */
+        public void acceptBoolean(int idx, String name);
 
 Review comment:
   How we simplify the code with several accept* methods? I see only 
duplication in 3 exporters implementations. And not sure about more quick code. 
We only saving some `if` branch checks for list headers generation. I think 
it's absolutely nothing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to