alex-plekhanov commented on a change in pull request #6845: IGNITE-12145:
Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r325225758
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/metric/jmx/JmxMetricExporterSpi.java
##########
@@ -31,41 +32,99 @@
import org.apache.ignite.spi.IgniteSpiException;
import org.apache.ignite.spi.metric.MetricExporterSpi;
import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.ReadOnlySystemViewRegistry;
+import org.apache.ignite.spi.metric.view.SystemView;
import org.jetbrains.annotations.Nullable;
import static
org.apache.ignite.internal.processors.metric.impl.MetricUtils.parse;
+import static org.apache.ignite.internal.util.IgniteUtils.makeMBeanName;
+import static org.apache.ignite.spi.metric.jmx.SystemViewMBean.VIEWS;
/**
* This SPI implementation exports metrics as JMX beans.
*/
public class JmxMetricExporterSpi extends IgniteSpiAdapter implements
MetricExporterSpi {
- /** Monitoring registry. */
+ /** Metric registry. */
private ReadOnlyMetricRegistry mreg;
+ /** Syste view registry. */
+ private ReadOnlySystemViewRegistry mlreg;
+
/** Metric filter. */
- private @Nullable Predicate<MetricRegistry> filter;
+ private @Nullable Predicate<MetricRegistry> metricFilter;
+
+ /** System view filter. */
+ private @Nullable Predicate<SystemView<?>> systeViewFilter;
Review comment:
syste**m**ViewFilter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
