alex-plekhanov commented on a change in pull request #6898: IGNITE-12211: Client connections system view URL: https://github.com/apache/ignite/pull/6898#discussion_r327693309
########## File path: modules/core/src/test/java/org/apache/ignite/internal/metric/JmxExporterSpiTest.java ########## @@ -62,6 +69,9 @@ import static org.apache.ignite.internal.processors.metric.GridMetricManager.GC_CPU_LOAD_DESCRIPTION; import static org.apache.ignite.internal.processors.metric.GridMetricManager.SYS_METRICS; import static org.apache.ignite.internal.processors.metric.impl.MetricUtils.metricName; +import static org.apache.ignite.internal.processors.odbc.ClientListenerProcessor.CLI_CONN_SYS_VIEW; +import static org.apache.ignite.internal.processors.odbc.jdbc.JdbcConnectionContext.CURRENT_VER; +import static org.apache.ignite.internal.processors.platform.client.ClientConnectionContext.DEFAULT_VER; Review comment: You should not check server version here, because the client doesn't necessarily have the same version (it can be lower). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
