agura commented on a change in pull request #6896: IGNITE-12209: Transactions 
system view.
URL: https://github.com/apache/ignite/pull/6896#discussion_r328677404
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteInternalTx.java
 ##########
 @@ -44,7 +45,7 @@
 /**
  * Transaction managed by cache ({@code 'Ex'} stands for external).
  */
-public interface IgniteInternalTx {
+public interface IgniteInternalTx extends TransactionView {
 
 Review comment:
   Please, prefer composition over inheritance. Actually `IgniteInternalTx` is 
not `TransactionView`. 
   Composition is also consistent with other existing  view implentations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to