andrey-kuznetsov commented on a change in pull request #6904: IGNITE-12220
URL: https://github.com/apache/ignite/pull/6904#discussion_r331553546
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/security/cache/CacheOperationPermissionCheckTest.java
##########
@@ -23,51 +23,106 @@
import java.util.function.Consumer;
import org.apache.ignite.Ignite;
import org.apache.ignite.IgniteCache;
-import
org.apache.ignite.internal.processors.security.AbstractCacheOperationPermissionCheckTest;
+import org.apache.ignite.internal.processors.security.AbstractSecurityTest;
import org.apache.ignite.plugin.security.SecurityException;
+import org.apache.ignite.plugin.security.SecurityPermission;
+import org.apache.ignite.plugin.security.SecurityPermissionSet;
import org.apache.ignite.plugin.security.SecurityPermissionSetBuilder;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import static java.util.Collections.singletonMap;
+import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_CREATE;
+import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_DESTROY;
import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_PUT;
import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_READ;
import static
org.apache.ignite.plugin.security.SecurityPermission.CACHE_REMOVE;
+import static
org.apache.ignite.plugin.security.SecurityPermission.JOIN_AS_SERVER;
import static
org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause;
/**
* Test CRUD cache permissions.
*/
@RunWith(JUnit4.class)
-public class CacheOperationPermissionCheckTest extends
AbstractCacheOperationPermissionCheckTest {
- /** */
+public class CacheOperationPermissionCheckTest extends AbstractSecurityTest {
+ /** New cache for tests. */
+ protected static final String NEW_CACHE = "NEW_CACHE";
+
+ /** Cache name for tests. */
+ protected static final String ALL_PERM_TEST_CACHE = "ALL_PERM_TEST_CACHE";
+
+ /** Forbidden caches. */
+ protected static final String CREATE_TEST_CACHE = "CREATE_TEST_CACHE";
+ protected static final String EMPTY_PERM_TEST_CACHE =
"EMPTY_PERM_TEST_CACHE";
Review comment:
Please add separate comments: the difference is not obvious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
