AMashenkov commented on a change in pull request #4381: Adding experimental support for Intel Optane DC Persistent Memory URL: https://github.com/apache/ignite/pull/4381#discussion_r332904958
########## File path: modules/core/src/main/java/org/apache/ignite/Ignite.java ########## @@ -722,4 +723,11 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair, * @return {@link DataStorageMetrics} snapshot. */ public DataStorageMetrics dataStorageMetrics(); + + /** + * + * @return + */ + public GridKernalContext context(); Review comment: GridKernalContext is internal class and resides in 'internal' package. Ignite is a public API interface. Exposing internal class via public API method doesn't look like a good idea. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services