alex-plekhanov commented on a change in pull request #6911: IGNITE-12232 NPE
while node join processing
URL: https://github.com/apache/ignite/pull/6911#discussion_r335416398
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
##########
@@ -4737,7 +4741,7 @@ else if (!locNodeId.equals(node.id()) &&
ring.node(node.id()) != null) {
spi.marshaller(),
U.resolveClassLoader(spi.ignite().configuration()), node
);
- if
(!permissionsEqual(coordSubj.subject().permissions(),
subj.subject().permissions())) {
+ if (!permissionsEqual(getPermissions(coordSubj),
getPermissions(subj))) {
Review comment:
Why we only fix one usage of this method? Are `null`'s possible in another
branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
