shuliga commented on a change in pull request #6917: IGNITE-12189
Implementation correct limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r341199437
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java
##########
@@ -2821,11 +2821,12 @@ public void remove(GridCacheContext cctx, CacheDataRow
row)
* @param filters Key and value filters.
* @param <K> Key type.
* @param <V> Value type.
+ * @param limit Limits response records count. If 0 or less, the limit
considered to be Integer.MAX_VALUE, that is virtually no limit.
Review comment:
Under the hood Lucene uses `int numHits` as limit, so we cannot set it to
more than Integet.MAX_VALUE. Using of 'limit' is a common case for Full text
search. This means that setting limit to it's max value (by passing 0) will be
rather a rare case. Also the response length is limited by docs quantity in the
index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
