alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: 
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r341154486
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/pagemem/store/PageStore.java
 ##########
 @@ -17,14 +17,20 @@
 
 package org.apache.ignite.internal.pagemem.store;
 
+import java.io.Closeable;
 import java.nio.ByteBuffer;
 import org.apache.ignite.IgniteCheckedException;
 import 
org.apache.ignite.internal.processors.cache.persistence.StorageException;
 
 /**
  * Persistent store of pages.
  */
-public interface PageStore {
+public interface PageStore extends Closeable {
+    /**
+     * @param lsnr Page store listener to set.
+     */
+    public void setListener(PageStoreListener lsnr);
 
 Review comment:
   Usually, listener abstraction is used with `addListener` method, not 
`setListener`. If you need only one listener and exactly know that no new 
listeners will be needed in the future, you can inline call of that listener. 
But I think it's better to create `addListener` method and use it every time a 
new snapshot is started.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to