shuliga commented on issue #6917: IGNITE-12189 Implementation correct limit for 
TextQuery
URL: https://github.com/apache/ignite/pull/6917#issuecomment-548827790
 
 
   Regarding `List.subList` in `enqueue()` method.
   Your point seems reasonable; but conversion of  `Collection` into `List` 
touches methods `onPage()` and `onPageReady()`; there is a lot of reworking 
here. It should be definitely a separate ticket.
   Also please keep in mind that `subList()` is taken only for last page of 
data and its size is always less then `pageSize`. This might never be a 
performance issue point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to