ascherbakoff commented on a change in pull request #6796: IGNITE-12049 Allow
custom authenticators to use SSL certificates
URL: https://github.com/apache/ignite/pull/6796#discussion_r341591681
##########
File path:
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
##########
@@ -6775,6 +6776,16 @@ else if (msg instanceof TcpDiscoveryJoinRequestMessage)
{
TcpDiscoveryJoinRequestMessage req =
(TcpDiscoveryJoinRequestMessage)msg;
if (!req.responded()) {
+ if (sock instanceof SSLSocket &&
+
spi.ignite().configuration().isSslCertsTransmissionEnabled()) {
+ HashMap<String, Object> attrs = new
HashMap<>(req.node().getAttributes());
+
+ attrs.put(ATTR_SECURITY_CERTIFICATES,
((SSLSocket) sock).getSession()
+ .getPeerCertificateChain());
Review comment:
What guarantees the call to getPeerCertificateChain will return serializable
object ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
