Mmuzaf commented on a change in pull request #6554: IGNITE-11073: Backup page
store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r348527289
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/pagemem/store/PageStore.java
##########
@@ -17,14 +17,20 @@
package org.apache.ignite.internal.pagemem.store;
+import java.io.Closeable;
import java.nio.ByteBuffer;
import org.apache.ignite.IgniteCheckedException;
import
org.apache.ignite.internal.processors.cache.persistence.StorageException;
/**
* Persistent store of pages.
*/
-public interface PageStore {
+public interface PageStore extends Closeable {
Review comment:
It used for PageStore recovery. You are not able to file the `close` method
usages since `try-with-resource` is used. Please, check `sendDelta` method of
the `LocalSnapshotSender`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
