nizhikov commented on a change in pull request #7319: IGNITE-12583 : refactored
JdbcThinBulkLoadAbstractSelfTest into a parametrized one
URL: https://github.com/apache/ignite/pull/7319#discussion_r371714191
##########
File path:
modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinBulkLoadSelfTest.java
##########
@@ -89,6 +94,31 @@
/** JDBC statement. */
private Statement stmt;
+ /** Parametrized run param : cacheMode */
+ @Parameterized.Parameter(0)
+ public CacheMode cacheMode;
+
+ /** Parametrized run param : atomicity */
+ @Parameterized.Parameter(1)
+ public CacheAtomicityMode atomicityMode;
+
+ /** Parametrized run param : near mode */
+ @Parameterized.Parameter(2)
+ public Boolean isNear;
+
+ /** Test run configurations: Cache mode, atomicity type, is near */
+ @Parameterized.Parameters
+ public static Collection<Object[]> runConfig() {
+ return Arrays.asList(new Object[][] {
+ { PARTITIONED, CacheAtomicityMode.ATOMIC, true },
Review comment:
We should use static import in both cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
