agura commented on a change in pull request #7332: IGNITE-12598: Cache metrics
configuration should be removed only on cache destroy
URL: https://github.com/apache/ignite/pull/7332#discussion_r374822813
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
##########
@@ -659,13 +659,15 @@ protected final String startInfo() {
/**
* Stops this cache. Child classes should override this method
* to provide custom stop behavior.
+ *
+ * @param destroy Destroy data flag. Setting to <code>true</code> will
remove all cache data.
*/
- public void stop() {
+ public void stop(boolean destroy) {
// Nulling thread local reference to ensure values will be eventually
GCed
// no matter what references these futures are holding.
lastFut = null;
- if (!ctx.kernalContext().isStopping())
+ if (!ctx.kernalContext().isStopping() && destroy)
Review comment:
Could be just removed (condition and statement under it). See my comment to
`GridCacheProcessor.stopCache()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
