Vladsz83 commented on a change in pull request #7358: IGNITE-12614 : Disallow
silent deactivation of cluster to prevent in-mem data loss.
URL: https://github.com/apache/ignite/pull/7358#discussion_r376385251
##########
File path:
modules/core/src/main/java/org/apache/ignite/mxbean/IgniteMXBean.java
##########
@@ -380,23 +376,30 @@
*/
@MXBeanDescription("Pings node with given node ID to see whether it is
alive. " +
"Returns whether or not node is alive.")
- @MXBeanParametersNames(
- "nodeId"
- )
- @MXBeanParametersDescriptions(
- "String presentation of node ID. See java.util.UUID class for details."
- )
+ @MXBeanParametersNames("nodeId")
+ @MXBeanParametersDescriptions("String presentation of node ID. See
java.util.UUID class for details.")
public boolean pingNode(String nodeId);
+ /** Activates cluster. */
+ @MXBeanDescription("Execute activation process.")
+ @MXBeanParametersNames("active")
+ public void activate();
+
+ /** Deactivates cluster. */
+ @MXBeanDescription("Execute deactivation process.")
+ @MXBeanParametersNames("force")
Review comment:
> > But this is an JMX. I don't think it is unsafe to add single param.
>
> Why do you think so?
An automated, external system like Zabbix of something must use exposed bean
to be afraid of it. Manual method invocation in the console is quite obvious.
Just requires to say extra ‘yes’ or ‘no’ for the new argument. Direct bean
usage within the code isn't reasonable except the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
