rkondakov commented on a change in pull request #7377: IGNITE-12602 Calcite
integration. JDBC Thin driver support.
URL: https://github.com/apache/ignite/pull/7377#discussion_r378194065
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/MessageServiceImpl.java
##########
@@ -189,32 +187,16 @@ public FailureProcessor failureProcessor() {
}
/** {@inheritDoc} */
- @Override public void send(Collection<UUID> nodeIds, CalciteMessage msg) {
- for (UUID nodeId : nodeIds)
- send(nodeId, msg);
- }
-
- /** {@inheritDoc} */
- @Override public void send(UUID nodeId, CalciteMessage msg) {
+ @Override public void send(UUID nodeId, CalciteMessage msg) throws
IgniteCheckedException {
if (localNodeId().equals(nodeId))
onMessage(nodeId, msg, true);
Review comment:
Can we get into some troubles (races?) here because of handling the message
in the current thread instead of submitting it into the specified pool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
