agura commented on a change in pull request #7394: IGNITE-10698: Get rid of
@MXBeanParametersNames and @MXBeanParametersDescriptions
URL: https://github.com/apache/ignite/pull/7394#discussion_r379554118
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/mxbean/IgniteStandardMXBean.java
##########
@@ -179,11 +181,23 @@
assert !str.trim().isEmpty();
// Enforce proper English.
- assert Character.isUpperCase(str.charAt(0)) == true : str;
+ assert Character.isUpperCase(str.charAt(0)) : str;
assert str.charAt(str.length() - 1) == '.' : str;
+ } else {
+ MXBeanParameterInfo argumentInfoAnnotation =
getMXBeanArgumentAnnotation(m, seq);
+
+ if (argumentInfoAnnotation != null) {
+ str = argumentInfoAnnotation.description();
+
+ assert str != null;
Review comment:
Could you please add clear messages for case when assert failed for all
assertions under this `if`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
