alex-plekhanov commented on a change in pull request #6554: IGNITE-11073:
Backup page store manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r387728682
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/binary/CacheObjectBinaryProcessorImpl.java
##########
@@ -533,6 +536,11 @@ public GridBinaryMarshaller marshaller() {
binaryCtx.updateMetadata(typeId, meta, false);
}
+ /** {@inheritDoc} */
+ @Override public BinaryTypeWriter createBinaryWriter(String igniteWorkDir)
{
+ return new BinaryMetadataFileStore(metadataLocCache, ctx, log,
igniteWorkDir, binaryMetadataFileStoreDir);
Review comment:
Also, you don't need `metadataLocCache` for snapshot creation, I think it's
better to create `BinaryMetadataFileStore` directly using constructor in
snapshot manager and remove this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
