Vladsz83 commented on a change in pull request #7471: IGNITE-12701 : Disallow
silent deactivation in CLI and REST.
URL: https://github.com/apache/ignite/pull/7471#discussion_r389878598
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/GridClusterStateProcessor.java
##########
@@ -1617,6 +1643,7 @@ public ExchangeActions
autoAdjustExchangeActions(ExchangeActions exchActs) {
ctx.localNodeId(),
null,
ClusterState.active(clusterState.state()) ?
clusterState.state() : ACTIVE,
+ true,
Review comment:
> It's not clear why we force deactivation here.
All previous internal changes of cluster state were forced. Thus, all
current internal changes of cluster are considered forced. Only the exceptions
are the user commands being translated to not-forced internal calls without
flag ‘force’ passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
