rkondakov commented on a change in pull request #7520: IGNITE-12632: Support of cancel command for resource-consuming entities. URL: https://github.com/apache/ignite/pull/7520#discussion_r394174120
########## File path: modules/core/src/main/java/org/apache/ignite/internal/QueryMXBeanImpl.java ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.util.UUID; +import org.apache.ignite.IgniteCompute; +import org.apache.ignite.IgniteLogger; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.cluster.IgniteClusterImpl; +import org.apache.ignite.internal.util.typedef.T2; +import org.apache.ignite.internal.util.typedef.internal.A; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.internal.visor.VisorTaskArgument; +import org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTask; +import org.apache.ignite.internal.visor.query.VisorContinuousQueryCancelTaskArg; +import org.apache.ignite.internal.visor.query.VisorQueryCancelTask; +import org.apache.ignite.internal.visor.query.VisorQueryCancelTaskArg; +import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTask; +import org.apache.ignite.internal.visor.query.VisorScanQueryCancelTaskArg; +import org.apache.ignite.mxbean.QueryMXBean; + +import static org.apache.ignite.internal.sql.command.SqlKillQueryCommand.parseGlobalQueryId; + +/** + * QueryMXBean implementation. + */ +public class QueryMXBeanImpl implements QueryMXBean { + /** */ + public static final String EXPECTED_GLOBAL_QRY_ID_FORMAT = "Global query id should have format " + + "'{node_id}_{query_id}', e.g. '6fa749ee-7cf8-4635-be10-36a1c75267a7_54321'"; + + /** */ + private final GridKernalContext ctx; + + /** */ + private final IgniteLogger log; + + /** + * @param ctx Context. + */ + public QueryMXBeanImpl(GridKernalContext ctx) { + this.ctx = ctx; + this.log = ctx.log(QueryMXBeanImpl.class); + } + + /** {@inheritDoc} */ + @Override public void cancelContinuous(String routineId) { + A.notNull(routineId, "routineId"); + + cancelContinuous(UUID.fromString(routineId)); + } + + /** {@inheritDoc} */ + @Override public void cancelSQL(String id) { + A.notNull(id, "id"); + + if (log.isInfoEnabled()) + log.info("Killing sql query[id=" + id + ']'); + + boolean res; + + try { + IgniteClusterImpl cluster = ctx.cluster().get(); + + T2<UUID, Long> ids = parseGlobalQueryId(id); + + if (ids == null) + throw new IllegalArgumentException("Expected global query id. " + EXPECTED_GLOBAL_QRY_ID_FORMAT); + + res = cluster.compute().execute(new VisorQueryCancelTask(), + new VisorTaskArgument<>(ids.get1(), new VisorQueryCancelTaskArg(ids.get1(), ids.get2()), false)); + } + catch (Exception e) { + throw new RuntimeException(e); + } + + if (!res) + throw new RuntimeException("Query not found[id=" + id + ']'); + } + + /** {@inheritDoc} */ + @Override public void cancelScan(String originNodeId, String cacheName, Long id) { + A.notNullOrEmpty(originNodeId, "originNodeId"); + A.notNullOrEmpty(cacheName, "cacheName"); + A.notNull(id, "id"); + + if (log.isInfoEnabled()) + log.info("Killing scan query[id=" + id + ",originNodeId=" + originNodeId + ']'); + + cancelScan(UUID.fromString(originNodeId), cacheName, id); + } + + /** + * Kills scan query by the identifiers. + * + * @param originNodeId Originating node id. + * @param cacheName Cache name. + * @param id Scan query id. + */ + public void cancelScan(UUID originNodeId, String cacheName, long id) { + boolean res; + + try { + IgniteClusterImpl cluster = ctx.cluster().get(); + + ClusterNode srv = U.randomServerNode(ctx); Review comment: I think we need to have a single entry point for the query cancellation. And this entry point should be located on the initiator. I can name a few reasons for it: 1. Convenience: single entry point is easier to control. If we want to add extra functionality to it (i.e. track statistics), we need to add it to the just one place. 2. Clean code: it is much easier to understand the code which has only one entry point for each operation. 3. Effectiveness: we send cancellation task to the all cluster nodes, but it might be excessive. The query can be finished on some nodes by the time of cancellation. Or query might be initially executed on a few nodes or a single node due to partition pruning. Only the initiator knows the actual query status and mapping, and therefore it should be responsible for the cancellation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
