andrey-kuznetsov commented on a change in pull request #7566: IGNITE-12832 Add
user attributes support to control.sh
URL: https://github.com/apache/ignite/pull/7566#discussion_r397931652
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandHandlerParsingTest.java
##########
@@ -277,6 +291,59 @@ public void testParseAndValidateSSLArguments() {
}
}
+ /**
+ * Tests parsing user attribute arguments from string.
+ */
+ @Test
+ public void testParseUserAttrStringArguments() {
+ List<String> cmdArgs = new ArrayList<>(DFLT_ARGS);
+
+ cmdArgs.add(CommandList.TX.text());
+ cmdArgs.add(CommonArgParser.CMD_USER_ATTR);
+ cmdArgs.add("attr1=val1,attr2=val2,attr3=mode=test");
+
+ ConnectionAndSslParameters args = parseArgs(cmdArgs);
+
+ assertEquals(args.userAttributes().get("attr1"), "val1");
+ assertNotEquals(args.userAttributes().get("attr1"), "val2");
+ assertEquals(args.userAttributes().get("attr3"), "mode=test");
+ }
+
+ /**
+ * Tests parsing user attribute arguments from file.
+ */
+ @Test
+ public void testParseUserAttrFileArguments() {
+ List<String> cmdArgs = new ArrayList<>(DFLT_ARGS);
+
+ cmdArgs.add(CommandList.TX.text());
+ cmdArgs.add(CommonArgParser.CMD_USER_ATTR_PATH);
+
cmdArgs.add(IgniteUtils.resolveIgnitePath(USER_ATTRIBUTE_PATH).getAbsolutePath());
+
+ ConnectionAndSslParameters args = parseArgs(cmdArgs);
+
+ assertEquals(args.userAttributes().get("attr3"), "val3");
+ assertEquals(args.userAttributes().get("attr4"), "mode=test");
+ }
+
+ /**
+ * Tests parsing user attribute arguments from file.
+ */
+ @Test
+ public void testParseUserAttrStringFileArguments() {
+ List<String> cmdArgs = new ArrayList<>(DFLT_ARGS);
+
+ cmdArgs.add(CommandList.TX.text());
+ cmdArgs.add(CommonArgParser.CMD_USER_ATTR_PATH);
+
cmdArgs.add(IgniteUtils.resolveIgnitePath(USER_ATTRIBUTE_PATH).getAbsolutePath());
+ cmdArgs.add(CommonArgParser.CMD_USER_ATTR);
+ cmdArgs.add("attr1=val1,attr3=val4");
+
+ ConnectionAndSslParameters args = parseArgs(cmdArgs);
+
+ assertEquals(args.userAttributes().get("attr3"), "val4");
Review comment:
We are to ensure all other attributes from both sources are still here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
