ptupitsyn commented on a change in pull request #7572: IGNITE-12835 Thin
client: compute support
URL: https://github.com/apache/ignite/pull/7572#discussion_r400814670
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Configuration/ThinClientConfiguration.cs
##########
@@ -29,18 +29,31 @@ public class ThinClientConfiguration
/// </summary>
public const int DefaultMaxActiveTxPerConnection = 100;
+ /// <summary>
+ /// Default limit of active compute tasks per connection.
+ /// </summary>
+ public const int DefaultMaxActiveComputeTasksPerConnection = 0;
+
/// <summary>
/// Initializes a new instance of the <see
cref="ThinClientConfiguration"/> class.
/// </summary>
public ThinClientConfiguration()
{
MaxActiveTxPerConnection = DefaultMaxActiveTxPerConnection;
+ MaxActiveComputeTasksPerConnection =
DefaultMaxActiveComputeTasksPerConnection;
}
/// <summary>
/// Gets or sets active transactions count per connection limit.
/// </summary>
[DefaultValue(DefaultMaxActiveTxPerConnection)]
public int MaxActiveTxPerConnection { get; set; }
+
+ /// <summary>
+ /// Gets or sets active compute tasks per connection limit.
+ /// Value <c>0</c> means that compute grid functionality is disabled
for thin clients.
+ /// </summary>
+ [DefaultValue(DefaultMaxActiveComputeTasksPerConnection)]
+ public int MaxActiveComputeTasksPerConnection { get; set; }
Review comment:
Thank you for updating .NET configuration and tests :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
