Vladsz83 commented on a change in pull request #7446: IGNITE-12464 : Service
metrics
URL: https://github.com/apache/ignite/pull/7446#discussion_r401115708
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
##########
@@ -188,6 +216,9 @@
/** Disconnected flag. */
private volatile boolean disconnected;
+ /** Keeps histograms to measure durations of service methods. Guided by
service name, then method name. */
+ private final Map<String, Map<String, MethodHistogramHolder>>
invocationHistograms = new HashMap<>(1);
Review comment:
This is not cached variable, not a class property. It is re-requested every
time. Yes, some gap in getting histogram is possible. But why long?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
