x-kreator commented on a change in pull request #7615: IGNITE-12764 Regression: Thin JDBC streaming fails/BatchUpdateException if function is used URL: https://github.com/apache/ignite/pull/7615#discussion_r405379033
########## File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java ########## @@ -691,36 +691,58 @@ private long streamQuery0(String qry, String schemaName, IgniteDataStreamer stre try { UpdatePlan plan = dml.plan(); - List<List<?>> planRows = plan.createRows(args != null ? args : X.EMPTY_OBJECT_ARRAY); + Object[] params = args != null ? args : X.EMPTY_OBJECT_ARRAY; + + Iterator<List<?>> iter0; + + if (!F.isEmpty(plan.selectQuery())) { + SqlFieldsQuery selectQry = new SqlFieldsQuery(plan.selectQuery()) + .setArgs(params) + .setLocal(true); Review comment: That behavior was implemented before was dropped at commit 6c9a17b4 (pr #6096 by vozerov), so I decided to return it with minimal differences. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services