x-kreator commented on a change in pull request #7680:
URL: https://github.com/apache/ignite/pull/7680#discussion_r411613064



##########
File path: 
modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteBinaryCacheQueryTestSuite.java
##########
@@ -585,7 +586,8 @@
     RowCountTableStatisticsSurvivesNodeRestartTest.class,
 
     SqlViewExporterSpiTest.class,
-    SystemViewSelfTest.class
+    SystemViewSelfTest.class,
+    QueryCursorSpliteratorCallsTest.class

Review comment:
       The list of suite's classes is divided into several named blocks marked 
with comments. Please, find the comment `// Queries tests.` and move this line 
to the end of that block.
   Also, please pay attention to my today's comment on class 
QueryKeyValueSpliterator at line 48 about `@Override` annotation.
   I recommend to fetch the upstream/master branch and merge it to your PR's 
branch before next push.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to