x-kreator edited a comment on issue #7704: URL: https://github.com/apache/ignite/pull/7704#issuecomment-617779697
> > > > Looks good to me, but you should re-run ~Run-All TC task~ possible blockers of your PR until no blockers found for that (`Results ready` button will green and contain '0' caption) and then publish the approval to jira ticket by pressing the `Comment JIRA` button. > > > > Upd: Easy way is to go into [Show pull/7704/head report](https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/7704/head&action=Latest) page and press `Re-run possible blockers` button there. > > > > > > > > > Thank you, I got lost in TC searching for failed tests. :) > > > > > > FYI: [TC Builds page](https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll?branch=pull%2F7704%2Fhead&buildTypeTab=overview&mode=builds) of this PR. > > master branch tests are failing. Should I clean (some of) them up? Since some are trivial (add a .travis.yml exclude to apache-rat-plugin)... > > ps: you have an interesting git workflow for a complex project Some tests at master branch can fail occasionally, you should exclude the influence of your changes by several re-runs of failed tests, the most of them should pass without failures. In case when you get some repeatedly failed tests, i.e. blockers count won't zeroed after several runs (3-5), you'll have to research those tests for affecting by your changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
