Mmuzaf commented on a change in pull request #7607: URL: https://github.com/apache/ignite/pull/7607#discussion_r414485421
########## File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotSelfTest.java ########## @@ -0,0 +1,895 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.persistence.snapshot; + +import java.io.File; +import java.io.IOException; +import java.io.Serializable; +import java.nio.file.OpenOption; +import java.util.Collections; +import java.util.List; +import java.util.concurrent.Callable; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.ThreadLocalRandom; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.function.Predicate; +import org.apache.ignite.Ignite; +import org.apache.ignite.IgniteCache; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.Ignition; +import org.apache.ignite.cache.CacheAtomicityMode; +import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction; +import org.apache.ignite.cache.query.ScanQuery; +import org.apache.ignite.configuration.CacheConfiguration; +import org.apache.ignite.configuration.IgniteConfiguration; +import org.apache.ignite.internal.IgniteEx; +import org.apache.ignite.internal.IgniteInternalFuture; +import org.apache.ignite.internal.IgniteInterruptedCheckedException; +import org.apache.ignite.internal.NodeStoppingException; +import org.apache.ignite.internal.TestRecordingCommunicationSpi; +import org.apache.ignite.internal.events.DiscoveryCustomEvent; +import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage; +import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionDemandMessage; +import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionSupplyMessage; +import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture; +import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.PartitionsExchangeAware; +import org.apache.ignite.internal.processors.cache.persistence.file.FileIO; +import org.apache.ignite.internal.processors.cache.persistence.file.FileIOFactory; +import org.apache.ignite.internal.processors.cache.persistence.file.RandomAccessFileIOFactory; +import org.apache.ignite.internal.processors.cache.persistence.partstate.GroupPartitionId; +import org.apache.ignite.internal.processors.metric.MetricRegistry; +import org.apache.ignite.internal.processors.metric.impl.ObjectGauge; +import org.apache.ignite.internal.util.distributed.DistributedProcess; +import org.apache.ignite.internal.util.distributed.FullMessage; +import org.apache.ignite.internal.util.distributed.SingleNodeMessage; +import org.apache.ignite.internal.util.typedef.G; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.lang.IgniteFuture; +import org.apache.ignite.spi.metric.LongMetric; +import org.apache.ignite.testframework.GridTestUtils; +import org.apache.ignite.transactions.Transaction; +import org.junit.Before; +import org.junit.Test; + +import static org.apache.ignite.cluster.ClusterState.ACTIVE; +import static org.apache.ignite.internal.events.DiscoveryCustomEvent.EVT_DISCOVERY_CUSTOM_EVT; +import static org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteSnapshotManager.SNAPSHOT_METRICS; +import static org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteSnapshotManager.SNP_IN_PROGRESS_ERR_MSG; +import static org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteSnapshotManager.SNP_NODE_STOPPING_ERR_MSG; +import static org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteSnapshotManager.isSnapshotOperation; +import static org.apache.ignite.internal.processors.cache.persistence.snapshot.IgniteSnapshotManager.resolveSnapshotWorkDirectory; +import static org.apache.ignite.testframework.GridTestUtils.assertThrowsAnyCause; +import static org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause; + +/** + * Cluster-wide snapshot test. + */ +public class IgniteClusterSnapshotSelfTest extends AbstractSnapshotSelfTest { + /** Time to wait while rebalance may happen. */ + private static final long REBALANCE_AWAIT_TIME = GridTestUtils.SF.applyLB(10_000, 3_000); + + /** Cache configuration for test. */ + private static CacheConfiguration<Integer, Integer> atomicCcfg = new CacheConfiguration<Integer, Integer>("atomicCacheName") + .setAtomicityMode(CacheAtomicityMode.ATOMIC) + .setBackups(2) + .setAffinity(new RendezvousAffinityFunction(false) + .setPartitions(CACHE_PARTS_COUNT)); + + /** {@code true} if node should be started in separate jvm. */ + protected volatile boolean jvm; + + /** @throws Exception If fails. */ + @Before + @Override public void beforeTestSnapshot() throws Exception { + super.beforeTestSnapshot(); + + jvm = false; + } + + /** + * Take snapshot from the whole cluster and check snapshot consistency when the + * cluster tx load starts on a new topology version. + * Note: Client nodes and server nodes not in baseline topology must not be affected. + * + * @throws Exception If fails. + */ + @Test + public void testConsistentClusterSnapshotLoadNewTopology() throws Exception { + int grids = 3; + String snpName = "backup23012020"; + AtomicInteger atKey = new AtomicInteger(CACHE_KEYS_RANGE); + AtomicInteger txKey = new AtomicInteger(CACHE_KEYS_RANGE); + + IgniteEx ignite = startGrids(grids); + startClientGrid(); + + ignite.cluster().baselineAutoAdjustEnabled(false); + ignite.cluster().state(ACTIVE); + + // Start node not in baseline. + IgniteEx notBltIgnite = startGrid(grids); + File locSnpDir = snp(notBltIgnite).snapshotLocalDir(SNAPSHOT_NAME); + String notBltDirName = folderName(notBltIgnite); + + IgniteCache<Integer, Integer> atCache = ignite.createCache(atomicCcfg); + + for (int idx = 0; idx < CACHE_KEYS_RANGE; idx++) { + atCache.put(atKey.incrementAndGet(), -1); + ignite.cache(DEFAULT_CACHE_NAME).put(txKey.incrementAndGet(), -1); + } + + forceCheckpoint(); + + CountDownLatch loadLatch = new CountDownLatch(1); + + ignite.context().cache().context().exchange().registerExchangeAwareComponent(new PartitionsExchangeAware() { + /** {@inheritDoc} */ + @Override public void onInitBeforeTopologyLock(GridDhtPartitionsExchangeFuture fut) { + if (fut.firstEvent().type() != EVT_DISCOVERY_CUSTOM_EVT) + return; + + // First discovery custom event will be a snapshot operation. + assertTrue(isSnapshotOperation(fut.firstEvent())); + assertTrue("Snapshot must use pme-free exchange", fut.context().exchangeFreeSwitch()); + } + + /** {@inheritDoc} */ + @Override public void onInitAfterTopologyLock(GridDhtPartitionsExchangeFuture fut) { + if (fut.firstEvent().type() != EVT_DISCOVERY_CUSTOM_EVT) + return; + + DiscoveryCustomMessage msg = ((DiscoveryCustomEvent)fut.firstEvent()).customMessage(); + + assertNotNull(msg); + + if (msg instanceof SnapshotDiscoveryMessage) + loadLatch.countDown(); + } + }); + + // Start cache load. + IgniteInternalFuture<Long> loadFut = GridTestUtils.runMultiThreadedAsync(() -> { + try { + U.await(loadLatch); + + while (!Thread.currentThread().isInterrupted()) { + ThreadLocalRandom rnd = ThreadLocalRandom.current(); + + int atIdx = rnd.nextInt(grids); + + // Zero out the sign bit. + grid(atIdx).cache(atomicCcfg.getName()).put(txKey.incrementAndGet(), rnd.nextInt() & Integer.MAX_VALUE); + + int txIdx = rnd.nextInt(grids); + + grid(txIdx).cache(DEFAULT_CACHE_NAME).put(atKey.incrementAndGet(), rnd.nextInt() & Integer.MAX_VALUE); + } + } + catch (IgniteInterruptedCheckedException e) { + throw new RuntimeException(e); + } + }, 3, "cache-put-"); + + try { + IgniteFuture<Void> fut = ignite.snapshot().createSnapshot(snpName); + + U.await(loadLatch, 10, TimeUnit.SECONDS); + + fut.get(); + } + finally { + loadFut.cancel(); + } + + // Cluster can be deactivated but we must test snapshot restore when binary recovery also occurred. + stopAllGrids(); + + assertTrue("Snapshot directory must be empty for node not in baseline topology: " + notBltDirName, + !searchDirectoryRecursively(locSnpDir.toPath(), notBltDirName).isPresent()); + + IgniteEx snpIg0 = startGridsFromSnapshot(grids, snpName); + + assertEquals("The number of all (primary + backup) cache keys mismatch for cache: " + DEFAULT_CACHE_NAME, + CACHE_KEYS_RANGE, snpIg0.cache(DEFAULT_CACHE_NAME).size()); + + assertEquals("The number of all (primary + backup) cache keys mismatch for cache: " + atomicCcfg.getName(), + CACHE_KEYS_RANGE, snpIg0.cache(atomicCcfg.getName()).size()); + + snpIg0.cache(DEFAULT_CACHE_NAME).query(new ScanQuery<>(null)) + .forEach(e -> assertTrue("Snapshot must contains only negative values " + + "[cache=" + DEFAULT_CACHE_NAME + ", entry=" + e +']', (Integer)e.getValue() < 0)); + + snpIg0.cache(atomicCcfg.getName()).query(new ScanQuery<>(null)) + .forEach(e -> assertTrue("Snapshot must contains only negative values " + + "[cache=" + atomicCcfg.getName() + ", entry=" + e + ']', (Integer)e.getValue() < 0)); + } + Review comment: Agree. I've added such a test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
