AMashenkov commented on a change in pull request #7851:
URL: https://github.com/apache/ignite/pull/7851#discussion_r430399878
##########
File path:
modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java
##########
@@ -203,6 +206,82 @@ public void testResultSetMetaData() throws Exception {
assert "java.lang.Integer".equals(meta.getColumnClassName(2));
}
+ /**
+ * Ensure metadata returned for cache without explicit query entities:
+ * - create a cache with indexed types and without explicit query
entities
+ * - request metadata for columns from the cache
+ * - verify returned result
Review comment:
It is not correct javadoc "list", it should be written in HTML style like
`<ul>
<li> .... </li>
</ul>`
So, it is a test though... who cares.
##########
File path:
modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java
##########
@@ -203,6 +206,82 @@ public void testResultSetMetaData() throws Exception {
assert "java.lang.Integer".equals(meta.getColumnClassName(2));
}
+ /**
+ * Ensure metadata returned for cache without explicit query entities:
+ * - create a cache with indexed types and without explicit query
entities
+ * - request metadata for columns from the cache
+ * - verify returned result
Review comment:
It is not correct javadoc "list", it should be written in HTML style like
```
<ul>
<li> .... </li>
</ul>
```
So, it is a test though... who cares.
##########
File path:
modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java
##########
@@ -1341,4 +1420,25 @@ private Department(int id, String name) {
this.name = name;
}
}
+
+ /** */
+ private enum MetadataColumn {
+ /** */ TABLE_SCHEMA("TABLE_SCHEM"),
Review comment:
New line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
