SammyVimes commented on a change in pull request #7792:
URL: https://github.com/apache/ignite/pull/7792#discussion_r430905612



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -419,6 +421,12 @@ public static void deleteSnapshot(File snpDir, String 
folderName) {
                 }
             });
 
+            File binMetadataDfltDir = new File(snpDir, 
DFLT_BINARY_METADATA_PATH);
+            File marshallerDfltDir = new File(snpDir, DFLT_MARSHALLER_PATH);
+
+            U.delete(binMetadataDfltDir);
+            U.delete(marshallerDfltDir);

Review comment:
       Do you mean it's necessary to check if directory exists prior to 
deleting it? It's just that I looked inside `U.delete` and it handles absence 
of files/directories by catching all `IOExceptions`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to