[GitHub] [ignite] dmekhanikov commented on pull request #8077: IGNITE-13288 Mark activation and baseline events as internal.

Wed, 29 Jul 2020 10:37:12 -0700 


dmekhanikov commented on pull request #8077:
URL: https://github.com/apache/ignite/pull/8077#issuecomment-665626871


   I think we can make `testClusterActivationEventsOnOtherNode` more strict.
   Something like this:
   ```
   Ignite ignite_1 = startGrid(0);
   Ignite ignite_2 = startGrid(1);
   
   CountDownLatch deactivatedLatch = addDisposableLocalListener(ignite_2, 
EVT_CLUSTER_DEACTIVATED);
   CountDownLatch stateChangedLatch1 = addDisposableLocalListener(ignite_2, 
EVT_CLUSTER_STATE_CHANGED);
   
   ignite_1.cluster().state(ClusterState.INACTIVE);
   
   assertTrue(deactivatedLatch.await(2, TimeUnit.SECONDS));
   assertTrue(stateChangedLatch1.await(2, TimeUnit.SECONDS));
   
   CountDownLatch activatedLatch = addDisposableLocalListener(ignite_2, 
EVT_CLUSTER_ACTIVATED);
   CountDownLatch stateChangedLatch2 = addDisposableLocalListener(ignite_2, 
EVT_CLUSTER_STATE_CHANGED);
   
   ignite_1.cluster().state(ClusterState.ACTIVE);
   
   assertTrue(activatedLatch.await(2, TimeUnit.SECONDS));
   assertTrue(stateChangedLatch2.await(2, TimeUnit.SECONDS));
   ```
   
   Otherwise the fix looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to