ivandasch commented on a change in pull request #8109:
URL: https://github.com/apache/ignite/pull/8109#discussion_r465112728
##########
File path:
modules/ducktests/src/main/java/org/apache/ignite/internal/ducktest/tests/DataGenerationApplication.java
##########
@@ -34,13 +35,13 @@ public DataGenerationApplication(Ignite ignite) {
}
/** {@inheritDoc} */
- @Override protected void run(String[] args) {
+ @Override protected void run(JsonNode jsonNode) {
log.info("Creating cache...");
- IgniteCache<Integer, Integer> cache = ignite.createCache(args[0]);
+ IgniteCache<Integer, Integer> cache =
ignite.createCache(jsonNode.get("cacheName").asText());
try (IgniteDataStreamer<Integer, Integer> stmr =
ignite.dataStreamer(cache.getName())) {
- for (int i = 0; i < Integer.parseInt(args[1]); i++) {
+ for (int i = 0; i < jsonNode.get("range").asInt(); i++) {
Review comment:
I think, that we should make in the bright future a generic application,
that accepts broad range of generic options to load data to cache. For example,
cache name, key-value schema (binary object), range for keys, number of keys,
etc.
For this argument DTO is a preferrable solution, I suppose. But we can
implement this a little bit later as a separate task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
