glukos commented on a change in pull request #8126:
URL: https://github.com/apache/ignite/pull/8126#discussion_r469094335
##########
File path: modules/core/src/main/java/org/apache/ignite/cache/CacheMetrics.java
##########
@@ -720,4 +720,18 @@
* @return Key collisions and appropriate queue size string representation.
*/
@NotNull public String getTxKeyCollisions();
+
+ /**
+ * Return {@code true} if index rebuild is in progress.
+ *
+ * @return {@code true} if index rebuild is in progress.
+ */
+ public boolean isIndexRebuildInProgress();
+
+ /**
+ * Return number of keys processed during index rebuilding.
Review comment:
Please explain as clear as possible how metric result should be
interpreted. We need to link method that retrieves local cache size here.
Also, wouldn't it be better to name this method
getIndexRebuildKey**s**Processed? We process multiple keys, not a single one.
##########
File path:
modules/core/src/main/java/org/apache/ignite/mxbean/CacheMetricsMXBean.java
##########
@@ -343,4 +343,12 @@
*/
@MXBeanDescription("Disable statistic collection for the cache.")
public void disableStatistics();
+
+ /** {@inheritDoc} */
+ @MXBeanDescription("True if index rebuilding in progress.")
+ @Override public boolean isIndexRebuildInProgress();
+
+ /** {@inheritDoc} */
+ @MXBeanDescription("Number of keys processed during index rebuilding.")
Review comment:
Please add clear explanation how to interpret result of this method to
JMX description as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
