glukos commented on a change in pull request #8113:
URL: https://github.com/apache/ignite/pull/8113#discussion_r469214228
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java
##########
@@ -174,10 +174,40 @@ public BinaryEnumObjectImpl(BinaryContext ctx, byte[]
arr) {
}
/** {@inheritDoc} */
- @Override public <T> T deserialize() throws BinaryObjectException {
- Class cls = BinaryUtils.resolveClass(ctx, typeId, clsName,
ctx.configuration().getClassLoader(), false);
+ @Override public <T> T deserialize(@Nullable ClassLoader ldr) throws
BinaryObjectException {
+ ClassLoader resolveLdr = ldr == null ?
ctx.configuration().getClassLoader() : ldr;
+
+ Class cls = BinaryUtils.resolveClass(ctx, typeId, clsName, resolveLdr,
false);
+
+ return (T)(ldr == null ? BinaryEnumCache.get(cls, ord) :
uncachedValue(cls));
+ }
+
+ /**
+ * Get value for the given class without any caching.
Review comment:
Seems like it's not actual: there's no parameter "ord"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
