glukos commented on a change in pull request #8146:
URL: https://github.com/apache/ignite/pull/8146#discussion_r470595478
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java
##########
@@ -706,6 +722,39 @@ public BinaryClassDescriptor descriptorForTypeId(
return desc;
}
+ /**
+ * Creates descriptor without registration.
+ *
+ * @param cls Class.
+ * @return Binary class descriptor.
+ */
+ @NotNull private BinaryClassDescriptor
createNoneCacheClassDescriptor(Class cls) {
+ String clsName = cls.getName();
+
+ BinaryInternalMapper mapper = userTypeMapper(clsName);
+
+ int typeId = mapper.typeId(clsName);
+
+ String typeName = mapper.typeName(clsName);
+
+ BinarySerializer serializer = serializerForClass(cls);
+
+ String affFieldName = affinityFieldName(cls);
+
+ return new BinaryClassDescriptor(this,
+ cls,
+ true,
+ typeId,
+ typeName,
+ affFieldName,
+ mapper,
+ serializer,
+ true,
+ true,
+ false
Review comment:
Shouldn't be a problem.
If instance is already present as a binary object, its class is not included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
