NSAmelchev commented on a change in pull request #8150:
URL: https://github.com/apache/ignite/pull/8150#discussion_r470605437
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/ClusterProcessor.java
##########
@@ -607,6 +610,33 @@ private Boolean findLastFlag(Collection<Serializable>
vals) {
U.error(log, "Failed to register MBean for cluster: ", e);
}
}
+
+ MetricRegistry reg = ctx.metric().registry(CLUSTER_METRICS);
+
+ reg.register("TopologyVersion",
Review comment:
We can use this metrics for the `ClusterMetricsMXBeanImpl`
implementation. But not for the `ClusterLocalNodeMetricsMXBeanImpl`.
Moreover metrics registration should be placed between starting
`GridMetricManager` and beans registration. For example, in the
`IgniteKernal#registerMetrics()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
