ivandasch commented on a change in pull request #8118:
URL: https://github.com/apache/ignite/pull/8118#discussion_r479224289
##########
File path:
modules/platforms/cpp/thin-client/include/ignite/impl/thin/transactions/transactions_proxy.h
##########
@@ -126,7 +127,7 @@ namespace ignite
ignite::thin::transactions::TransactionIsolation::Type isolation =
ignite::thin::transactions::TransactionIsolation::READ_COMMITTED,
int64_t timeout = 0,
int32_t txSize = 0,
- ignite::common::concurrent::SharedPointer<const
char> lbl = "");
+
ignite::common::concurrent::SharedPointer<ignite::common::FixedSizeArray<char>
> lbl = "");
Review comment:
Why empty string? default should be null string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
