timoninmaxim commented on a change in pull request #8206: URL: https://github.com/apache/ignite/pull/8206#discussion_r482832744
########## File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/KubernetesConnectorConfigurator.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.kubernetes; + +/** + * Interface provide methods to configure Kubernetes connection. + */ +public interface KubernetesConnectorConfigurator { Review comment: I can move this interface to package with finders and make it package-private, isn't it enough? Public API for IpFinder isn't changed, it still have the same setters. I'm agree that this interface doesn't look good but it's a limitation of exisiting IpFinder. Alternatives are: 1. Remove this interface and track k8s configuration params only with constructor of `KubernetesServiceAddressResolver`; 2. Provide a new object like `KubernetesConnectionKonfiguration` instead of interface, provide new IpFinder constructor that accept the configuration, deprecate setters in the IpFinder in favor of the constructor. I like the second option. But it lead change of the IpFinder API (add new, deprecate old), is it ok? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
