nizhikov commented on a change in pull request #8038:
URL: https://github.com/apache/ignite/pull/8038#discussion_r483040343



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
##########
@@ -836,7 +856,8 @@ else if (type == EVT_CLIENT_NODE_RECONNECTED) {
                                         discoCache0,
                                         notification.getTopSnapshot(),
                                         null,
-                                        notification.getSpanContainer()
+                                        notification.getSpanContainer(),
+                                        null

Review comment:
       Why null here?

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
##########
@@ -2233,6 +2259,7 @@ public void metricsUpdateEvent(DiscoCache discoCache, 
ClusterNode node) {
                 discoCache,
                 discoCache.nodeMap.values(),
                 null,
+                null,

Review comment:
       Why null here?

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
##########
@@ -2212,6 +2237,7 @@ public void clientCacheStartEvent(UUID reqId,
                     null,
                     Collections.<ClusterNode>emptyList(),
                     new ClientCacheChangeDummyDiscoveryMessage(reqId, 
startReqs, cachesToClose),
+                    null,

Review comment:
       Why null here?

##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
##########
@@ -2623,6 +2650,7 @@ public void scheduleSegmentCheck() {
                                     locNodeOnlyTop),
                                 locNodeOnlyTop,
                                 null,
+                                null,

Review comment:
       Why null here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to