ptupitsyn commented on a change in pull request #8206:
URL: https://github.com/apache/ignite/pull/8206#discussion_r485490144
##########
File path:
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
##########
@@ -115,18 +116,30 @@
/** Reconnect throttling retries. See {@code reconnectThrottlingPeriod}. */
private int reconnectThrottlingRetries = 3;
+ /** Retry limit. */
+ private int retryLimit = 0;
+
/**
* @return Host addresses.
*/
public String[] getAddresses() {
- return addrs;
+ return addrFinder.get();
Review comment:
`addrFinder` can be null
##########
File path:
modules/kubernetes/src/main/java/org/apache/ignite/client/ThinClientKubernetesAddressFinder.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+import java.net.InetAddress;
+import java.util.function.Supplier;
+import
org.apache.ignite.internal.kubernetes.connection.KubernetesServiceAddressResolver;
+import
org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Address finder for automatic lookup of Ignite server nodes running in
Kubernetes environment. All Ignite nodes have
+ * to be deployed as Kubernetes pods in order to be found. Applications and
Ignite nodes running outside of Kubernetes
+ * will not be able to reach the containerized counterparts.
+ * <p>
+ * The implementation is based on a distinct Kubernetes service. The name of
the service must be set with
+ * {@code KubernetesConnectionConfiguration}. As for Ignite pods, it's
recommended to label them in such a way that
+ * the service will target only server nodes.
+ * <p>
+ * The address finder, in its turn, will call this service to retrieve Ignite
pods IP addresses. The port will be
+ * set later within {@link IgniteClient}. Make sure that all Ignite pods
occupy a similar ClientConnector port,
+ * otherwise they will not be able to connect each other using this address
finder.
+ * <p>
+ */
+public class ThinClientKubernetesAddressFinder implements Supplier<String[]> {
+ /** Kubernetes connection configuration */
+ private final KubernetesConnectionConfiguration cfg;
+
+ /** Constructor */
+ public ThinClientKubernetesAddressFinder(KubernetesConnectionConfiguration
cfg) {
+ this.cfg = cfg;
+ }
+
+ /** {@inheritDoc} */
+ @Override public String[] get() {
+ return new KubernetesServiceAddressResolver(cfg)
Review comment:
Performance: do not create `KubernetesServiceAddressResolver` on every
call, create it once in constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
