anton-vinogradov commented on a change in pull request #8219: URL: https://github.com/apache/ignite/pull/8219#discussion_r486435555
########## File path: modules/ducktests/tests/ignitetest/services/utils/sql_util.py ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" +This module contains JDBC driver wrapper. +""" + +import random +import jaydebeapi +from ignitetest.services.ignite import IgniteService +from ignitetest.utils.version import DEV_BRANCH, IgniteVersion + + +def connection(ignite_service: IgniteService, ver: IgniteVersion = None): + """ + :param ignite_service: IgniteService. + :param ver: IgniteVersion jdbc driver for connection. + :return Connection. + """ + if ver is None: + ver = ignite_service.config.version + + vstr = ver.vstring + + if ver == DEV_BRANCH: + core_jar_path = str("modules/core/target/ignite-core-%s-SNAPSHOT.jar" % vstr) + else: + core_jar_path = str("/opt/ignite-%s/libs/ignite-core-%s.jar" % (vstr, vstr)) + + node = random.choice(ignite_service.nodes) Review comment: random makes failures unreproducible ########## File path: modules/ducktests/tests/ignitetest/tests/sql_jdbc_test.py ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" +This module contains SQL tests using the JDBC driver. +""" +from ducktape.mark.resource import cluster + +from ignitetest.services.ignite import IgniteService +from ignitetest.services.utils.ignite_configuration import IgniteConfiguration +from ignitetest.services.utils.sql_util import connection +from ignitetest.utils import ignite_versions +from ignitetest.utils.ignite_test import IgniteTest +from ignitetest.utils.version import DEV_BRANCH, V_2_8_1, V_2_8_0, V_2_7_6, IgniteVersion + + +# pylint: disable=W0223 +class SqlJdbcTest(IgniteTest): + """ + SQL tests using the JDBC driver. + """ + NUM_NODES = 3 + + @cluster(num_nodes=NUM_NODES) + # Note: DEV version does not support earlier versions before IGNITE-13414 resolution + @ignite_versions( + (str(DEV_BRANCH), str(DEV_BRANCH)), + (str(V_2_8_1), str(V_2_8_1)), (str(V_2_8_0), str(V_2_8_1)), + (str(V_2_8_1), str(V_2_8_0)), (str(V_2_8_0), str(V_2_8_0)), + (str(V_2_8_1), str(V_2_7_6)), (str(V_2_8_0), str(V_2_7_6)), (str(V_2_7_6), str(V_2_7_6)) Review comment: overcomplicated and required to be updated on release. how about to have some plain strategy, eg. to check previous, current, and next release on every version? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
